Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc build #2050

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Fix doc build #2050

merged 3 commits into from
Oct 11, 2024

Conversation

regisss
Copy link
Contributor

@regisss regisss commented Oct 10, 2024

What does this PR do?

Recent doc builds failed:

It seems Github runners are now configured differently, hence these errors. This PR fixes that.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@tengomucho
Copy link

The optimum-tpu installation fails because torch xla does not support python 3.12 yet, you need to use an earlier version (perhaps the simplest would be to use the ubuntu:22.04 image).

@regisss regisss marked this pull request as ready for review October 10, 2024 16:29
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix @regisss !

@echarlaix echarlaix merged commit 6172e96 into main Oct 11, 2024
45 of 48 checks passed
@echarlaix echarlaix deleted the fix_doc_build branch October 11, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants