Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ONNX export for transformers 4.45 #2045

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Enable ONNX export for transformers 4.45 #2045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39b940e
Enable ONNX export for transformers 4.45
echarlaix Oct 9, 2024
5642db2
add comment
echarlaix Oct 9, 2024
b3ef064
update setup
echarlaix Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions optimum/exporters/onnx/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@

import numpy as np
import onnx
import transformers
from transformers.modeling_utils import get_parameter_dtype
from transformers.utils import is_tf_available, is_torch_available

Expand Down Expand Up @@ -531,6 +530,11 @@ def export_pytorch(
logger.info(f"Using framework PyTorch: {torch.__version__}")
FORCE_ONNX_EXTERNAL_DATA = os.getenv("FORCE_ONNX_EXTERNAL_DATA", "0") == "1"

model_kwargs = model_kwargs or {}
# num_logits_to_keep was added in transformers 4.45 and isn't added as inputs when exporting the model
if check_if_transformers_greater("4.44.99") and "num_logits_to_keep" in signature(model.forward).parameters.keys():
model_kwargs["num_logits_to_keep"] = 0

with torch.no_grad():
model.config.return_dict = True
model = model.eval()
Expand Down Expand Up @@ -1001,11 +1005,6 @@ def onnx_export_from_model(
>>> onnx_export_from_model(model, output="gpt2_onnx/")
```
"""
if check_if_transformers_greater("4.44.99"):
raise ImportError(
f"ONNX conversion disabled for now for transformers version greater than v4.45, found {transformers.__version__}"
)

TasksManager.standardize_model_attributes(model)

if hasattr(model.config, "export_model_type"):
Expand Down
7 changes: 2 additions & 5 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
"datasets>=1.2.1",
"evaluate",
"protobuf>=3.20.1",
"transformers<4.45.0",
],
"onnxruntime-gpu": [
"onnx",
Expand All @@ -63,10 +62,9 @@
"evaluate",
"protobuf>=3.20.1",
"accelerate", # ORTTrainer requires it.
"transformers<4.45.0",
],
"exporters": ["onnx", "onnxruntime", "timm", "transformers<4.45.0"],
"exporters-gpu": ["onnx", "onnxruntime-gpu", "timm", "transformers<4.45.0"],
"exporters": ["onnx", "onnxruntime", "timm"],
"exporters-gpu": ["onnx", "onnxruntime-gpu", "timm"],
"exporters-tf": [
"tensorflow>=2.4,<=2.12.1",
"tf2onnx",
Expand All @@ -77,7 +75,6 @@
"numpy<1.24.0",
"datasets<=2.16",
"transformers[sentencepiece]>=4.26,<4.38",
"transformers<4.45.0",
],
"diffusers": ["diffusers"],
"intel": "optimum-intel>=1.18.0",
Expand Down
Loading