Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: device consistence #1891

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix: device consistence #1891

merged 2 commits into from
Jun 6, 2024

Conversation

Daya-Jin
Copy link
Contributor

@Daya-Jin Daya-Jin commented Jun 4, 2024

What does this PR do?

Fixes # (issue)
#1889

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@fxmarty, @SunMarc

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Daya-Jin. I left a comment

Edit: Nevermind, I just saw the issue #1889.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Please fix the quality test by running make style

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Daya-Jin
Copy link
Contributor Author

Daya-Jin commented Jun 4, 2024

LGTM ! Please fix the quality test by running make style

emm how? (sorry I have no idea how to fix the failed checklist)

@SunMarc
Copy link
Member

SunMarc commented Jun 4, 2024

emm how? (sorry this is my first PR on github. I have no idea how to fix the failed checklist)

No worries, just go to the optimum folder on your terminal (cd optimum), then run the following command : make style. This should format your code. LMK if this is clear !

@Daya-Jin
Copy link
Contributor Author

Daya-Jin commented Jun 5, 2024

emm how? (sorry this is my first PR on github. I have no idea how to fix the failed checklist)

No worries, just go to the optimum folder on your terminal (cd optimum), then run the following command : make style. This should format your code. LMK if this is clear !

(base) root@hjz_dev:/data3/optimum-patch-3# make style
make: Warning: File 'Makefile' has modification time 80134 s in the future
black .
reformatted /data3/optimum-patch-3/optimum/onnxruntime/runs/init.py
reformatted /data3/optimum-patch-3/optimum/gptq/quantizer.py

All done! ✨ ✨
2 files reformatted, 199 files left unchanged.
ruff . --fix
warning: ruff <path> is deprecated. Use ruff check <path> instead.
warning: The top-level linter settings are deprecated in favour of their counterparts in the lint section. Please update the following options in pyproject.toml:

  • 'ignore' -> 'lint.ignore'
  • 'select' -> 'lint.select'
  • 'isort' -> 'lint.isort'
  • 'per-file-ignores' -> 'lint.per-file-ignores'
    All checks passed!
    make: warning: Clock skew detected. Your build may be incomplete.

Aha I see. It changed the single quote to the double quote. About /data3/optimum-patch-3/optimum/onnxruntime/runs/init.py, I didn't edit it.

@SunMarc
Copy link
Member

SunMarc commented Jun 5, 2024

  • About /data3/optimum-patch-3/optimum/onnxruntime/runs/init.py, I didn't edit it.

No worries about this file if you didn't touch it. This might be an issue with the version of black or ruff. Thanks for fixing the quality issue ! This should be good to merge.

@fxmarty fxmarty merged commit 113b645 into huggingface:main Jun 6, 2024
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants