Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPTQ CI #1878

Merged
merged 14 commits into from
Jun 28, 2024
Merged

Fix GPTQ CI #1878

merged 14 commits into from
Jun 28, 2024

Conversation

IlyasMoutawwakil
Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil commented May 27, 2024

What does this PR do?

Fixes failures from the non reproducibility and non determinism (or lack of deterministic kernels when activated) by checking expected perplexity instead of specific outputs.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@IlyasMoutawwakil
Copy link
Member Author

all failures are generation correctness checks that pass locally on an A100, some outputs on t4 are very bad like Hello my name is A.I.I.I.I.

@echarlaix echarlaix requested a review from fxmarty May 28, 2024 14:49
@IlyasMoutawwakil IlyasMoutawwakil requested review from fxmarty and removed request for fxmarty June 26, 2024 12:02
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as it passes. Thank you for fixing

@IlyasMoutawwakil IlyasMoutawwakil merged commit 9c882fd into main Jun 28, 2024
43 of 49 checks passed
@IlyasMoutawwakil IlyasMoutawwakil deleted the fix-gptq-ci branch June 28, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants