Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix starcoder ORT integration #1722

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Feb 26, 2024

As pointed out by @BBerabi @lidingsnyk, _reorder_cache was missing for ORTGPTBigCodeForCausalLM, which makes beam search fail.

Fixes #1475

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@fxmarty
Copy link
Contributor Author

fxmarty commented Feb 27, 2024

Failing tests are unrelated

@fxmarty fxmarty merged commit c7cc312 into huggingface:main Feb 27, 2024
36 of 45 checks passed
young-developer pushed a commit to young-developer/optimum that referenced this pull request May 10, 2024
* fix starcoder ort

* fix pix2struct as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running inference pipeline with Starcoderbase model with ONNX Optimization crashes
3 participants