Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bt benchmarks #1189

Closed
wants to merge 5 commits into from
Closed

Bt benchmarks #1189

wants to merge 5 commits into from

Conversation

baskrahmer
Copy link
Contributor

What does this PR do?

Refactors the benchmark scripts; add CPU support.
Next step is to make a script to run these benchmarks on all BetterTransformer architectures and generate the speedup tables :)

Still need to test on GPU

#1125 (review)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@regisss
Copy link
Contributor

regisss commented Jul 15, 2023

@IlyasMoutawwakil Do we already support BetterTransformer in Optimum Benchmark?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 15, 2023

The documentation is not available anymore as the PR was closed or merged.

@IlyasMoutawwakil
Copy link
Member

@regisss Yep we do,

@baskrahmer
Copy link
Contributor Author

@regisss @IlyasMoutawwakil ah I did not know of this repo but it seems useful! That leaves me questioning the purpose of this PR and generally the need for benchmark scripts in the Optimum library.

@regisss
Copy link
Contributor

regisss commented Jul 17, 2023

@regisss @IlyasMoutawwakil ah I did not know of this repo but it seems useful! That leaves me questioning the purpose of this PR and generally the need for benchmark scripts in the Optimum library.

Not sure exactly if these scripts are still maintained. Maybe @fxmarty knows more about this?

@fxmarty
Copy link
Contributor

fxmarty commented Jul 24, 2023

Yes, these scripts are there for reproducibility for the blog posts we published on pytorch medium/blog.

Probably we should use @IlyasMoutawwakil work to generate the benchmark tables for BT.

@baskrahmer baskrahmer closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants