Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tying mechanism + small fixes #62

Merged
merged 9 commits into from
Feb 12, 2024
Merged

Conversation

NouamaneTazi
Copy link
Member

@NouamaneTazi NouamaneTazi commented Feb 12, 2024

  • fix tied embeddings in llama (we didn't tie before)
  • refactor KV weights tying

This PR is a preparation for a next PR to remove module_id_to_prefix from nanotron

✅ tied weights tests pass

Copy link
Member

@3outeille 3outeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@NouamaneTazi NouamaneTazi merged commit 939522e into main Feb 12, 2024
Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants