Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up dependency groups #81

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Tidy up dependency groups #81

merged 9 commits into from
Mar 4, 2024

Conversation

lewtun
Copy link
Member

@lewtun lewtun commented Mar 2, 2024

This PR reorganises the dependency groups so that things like ruff and pytest are not part of the core library. This is how we do it in the other HF libs and is important because when these utilities are pinned to specific versions, it is not simple to integrate lighteval within another codebase / environment where the versions can clash.

One added bonus, is that one can now just define:

pip install -e '.[dev]'

to get the core set of dependencies during development :)

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clefourrier clefourrier merged commit 7bf4087 into main Mar 4, 2024
2 checks passed
@lewtun lewtun deleted the tidy-deps branch March 4, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants