Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom metric system + IFEval as an example #48

Merged
merged 15 commits into from
Feb 28, 2024

Conversation

clefourrier
Copy link
Member

@clefourrier clefourrier commented Feb 23, 2024

Edit: might need some double check on validity of IfEval

@clefourrier clefourrier changed the title [WIP] Adding custom metric system Adding custom metric system Feb 23, 2024
@clefourrier clefourrier changed the title Adding custom metric system Adding custom metric system + IFEval as an example Feb 23, 2024
@lewtun
Copy link
Member

lewtun commented Feb 23, 2024

For reference, maybe we can use what Daniel found with the Eleuther harness here? EleutherAI/lm-evaluation-harness#1098 (comment)

We can also cross-check with the DeepSeek paper: https://arxiv.org/pdf/2401.02954.pdf

Screenshot 2024-02-23 at 20 23 37

pyproject.toml Show resolved Hide resolved
@NathanHB
Copy link
Member

Great work ! Looks really clean. has it been checked against known implem ?

@clefourrier
Copy link
Member Author

I still need to do some more checks on Monday, I'm not getting the numbers I was expecting for Zephyr

Co-authored-by: Nathan Habib <30601243+NathanHB@users.noreply.github.com>
@clefourrier clefourrier mentioned this pull request Feb 26, 2024
README.md Outdated Show resolved Hide resolved
@clefourrier
Copy link
Member Author

clefourrier commented Feb 28, 2024

@lewtun and I did manual tests and got similar results to the above analysis for a number of models, see Slack (Starling, DeepSeek LLM, Mistral, ...)

@clefourrier clefourrier merged commit acffc1a into main Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants