Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep target_for_fewshot_sorting for another purpose #241

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sadra-barikbin
Copy link
Contributor

@sadra-barikbin sadra-barikbin commented Jul 28, 2024

  • Removed task arg from FewShotSampler.init_fewshot_sampling_balanced() because it no longer needs it.
  • Removed fewshot arg from task.doc_to_target() and doc.get_golds() as it's no longer used.
  • Added get_target_for_fewshot_sorting() to Doc which gives target_for_fewshot_sorting if it's set otherwise gives the gold.
  • Adopted some of the tasks in the code to the change to check its viability.

Closes #240

@NathanHB
Copy link
Member

Hi ! Thanks for your PR, it appears the tests are not passing, I already took a look and it looks good but I will be reviewing more thourouly once the tests pass :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FT] To keep target_for_fewshot_sorting for another purpose
2 participants