Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for launching inference endpoint with different model dtypes #124

Merged
merged 8 commits into from
Mar 22, 2024

Conversation

shaltielshmid
Copy link
Contributor

Following the documentation here: https://huggingface.co/docs/text-generation-inference/en/basic_tutorials/launcher#quantize

If the dtype specified doesn't match any of our conditions, we don't specify anything and let it fallback to the default.

@clefourrier
Copy link
Member

clefourrier commented Mar 21, 2024

I need to test it in depth but from a first glance, it LGTM, it will work well with our logging system too, which is nice. Good job!
For next time, it would be great if you could check is someone else is already working on the related issue, to avoid duplicate work 🤗

Will fix #117 , linked to #120 .

@clefourrier clefourrier self-requested a review March 22, 2024 10:24
Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clefourrier clefourrier merged commit 07ca0b2 into huggingface:main Mar 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants