Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified system for extended tasks #123

Merged
merged 11 commits into from
Mar 27, 2024
Merged

Conversation

clefourrier
Copy link
Member

@clefourrier clefourrier commented Mar 20, 2024

Extended tasks are now included in the main lighteval code, though they will only be imported if dependencies are available.
Still need to find a way to provide all the tasks name somewhere, probably in the examples.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@clefourrier
Copy link
Member Author

@NathanHB do you need anything else for a review? :)

@clefourrier
Copy link
Member Author

Tests are failing because of a breaking change in huggingface_hub, which no longer has huggingface_hub.inference._text_generation.
@Wauplin would you advise up setting a lower or upper bound to your lib?

@Wauplin
Copy link
Contributor

Wauplin commented Mar 26, 2024

Tests are failing because of a breaking change in huggingface_hub, which no longer has huggingface_hub.inference._text_generation.
@Wauplin would you advise up setting a lower or upper bound to your lib?

Oopsi oopsi, sorry about that! 😬
I definitely advice to set a lower bound for huggingface_hub lib', otherwise you won't be able to upgrade anymore. I opened a PR to fix this: #129.

Copy link
Member

@NathanHB NathanHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clefourrier clefourrier merged commit e941a55 into main Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants