Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme #98

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Fix readme #98

merged 2 commits into from
Jun 1, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jun 1, 2022

This PR does the following changes to the README.md:

  • remove conda from installation instructions
  • fix link to how-to-guide

Closes #95

@lvwerra lvwerra requested a review from sashavor June 1, 2022 08:28
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 1, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@sashavor sashavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Why are we not using conda anymore though?

@lvwerra
Copy link
Member Author

lvwerra commented Jun 1, 2022

We did not distribute in on conda so this never worked. We will add it at some point, but as discussed with @LysandreJik it was not top priority for the initial release.

@sashavor
Copy link
Contributor

sashavor commented Jun 1, 2022 via email

@lvwerra lvwerra merged commit e179b5b into main Jun 1, 2022
@lvwerra lvwerra deleted the fix-readme branch July 24, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to step-by-step guide is broken.
3 participants