Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency #507

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Remove unused dependency #507

merged 1 commit into from
Dec 11, 2023

Conversation

daskol
Copy link
Contributor

@daskol daskol commented Oct 14, 2023

No description provided.

@sorgfresser
Copy link

Can we please get this merged? This is quite annoying as responses is already at v 24 and it's breaking a lot of environment stuff for me.

@daskol
Copy link
Contributor Author

daskol commented Dec 11, 2023

@sorgfresser There is no much activity since 2022 but let's try.

@lhoestq Any comments?

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR and sorry for taking so long to review ! responses is indeed not needed anymore

see responses removal PR in datasets: huggingface/datasets#5916

@lhoestq lhoestq merged commit dfbbf15 into huggingface:main Dec 11, 2023
@daskol daskol deleted the packaging/update-requirements branch December 11, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants