Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scikit-learn package name suggestion #498

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix scikit-learn package name suggestion #498

merged 1 commit into from
Sep 29, 2023

Conversation

bzz
Copy link
Contributor

@bzz bzz commented Sep 23, 2023 •
edited
Loading

Drive-by fix for #394 following project's code style.

pcuenca
pcuenca approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to suggest the same after I encountered the same issue in a new environment.

@bzz
Copy link
Contributor Author

bzz commented Sep 27, 2023

Great, thanks for the prompt review. Let me know if there is anything left before merging it!

@lvwerra lvwerra merged commit 937a8dd into huggingface:main Sep 29, 2023
6 checks passed
@bzz bzz deleted the fix-sklearn branch October 9, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcuenca pcuenca pcuenca approved these changes

@lvwerra lvwerra lvwerra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bzz @pcuenca @lvwerra