Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the documentation and citation of mauve #416

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

krishnap25
Copy link
Contributor

No description provided.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@lvwerra
Copy link
Member

lvwerra commented Feb 8, 2023

Can you run make style && make quality to make the quality tests pass?

metrics/mauve/mauve.py:45:190: W291 trailing whitespace
[17](https://github.com/huggingface/evaluate/actions/runs/4117623810/jobs/7109147950#step:5:18)
metrics/mauve/mauve.py:47:153: W291 trailing whitespace
[18](https://github.com/huggingface/evaluate/actions/runs/4117623810/jobs/7109147950#step:5:19)
metrics/mauve/mauve.py:48:155: W291 trailing whitespace

@lvwerra lvwerra requested a review from sashavor February 8, 2023 10:29
Copy link
Contributor

@sashavor sashavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, once the make style && make quality are done!

Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can merge once style and quality is fixed.

metrics/mauve/mauve.py Outdated Show resolved Hide resolved
metrics/mauve/mauve.py Outdated Show resolved Hide resolved
metrics/mauve/mauve.py Outdated Show resolved Hide resolved
@krishnap25
Copy link
Contributor Author

Hi Leandro, sorry I dropped the ball on this one. Is there anything action required from my side here?

Also, possibly unrelated, but it appears that Mauve's space is broken for some reason. Is there anything I can do to help fix it?

Thank you very much!

@krishnap25
Copy link
Contributor Author

krishnap25 commented Nov 1, 2023

@lvwerra Thank you so much for fixing the whitespace and it looks like all checks have passed. Can this PR be merged now?

@lvwerra lvwerra merged commit 1893285 into huggingface:main Nov 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants