Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add r^2 metric #407

Merged
merged 14 commits into from
Mar 14, 2023
Merged

add r^2 metric #407

merged 14 commits into from
Mar 14, 2023

Conversation

TarikKaanKoc
Copy link
Contributor

I turned off the old pr and rebuilt the pr to add the r_squared metric :) I tested it locally and it seems ok... @lvwerra

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 30, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, I think there is an issue with YAML formatting I pointed out.

metrics/r_squared/README.md Outdated Show resolved Hide resolved
@lvwerra
Copy link
Member

lvwerra commented Jan 30, 2023

Also looking at the CI it seems that your example returns got = '0.9795918322662046' which is different from what you specify which is why the doctest fails.

TarikKaanKoc and others added 2 commits January 31, 2023 12:51
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
@TarikKaanKoc
Copy link
Contributor Author

0.9795918322662046

I must have overlooked 👀 I have updated the expected metric result for example.

@TarikKaanKoc
Copy link
Contributor Author

This time there should be no error, would you check? @lvwerra

@lvwerra
Copy link
Member

lvwerra commented Feb 3, 2023

I think you might need another make syle && make quality :)

Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@lvwerra lvwerra merged commit 1145fab into huggingface:main Mar 14, 2023
unna97 pushed a commit to unna97/evaluate that referenced this pull request Mar 20, 2023
* add r^2  metric

* Update metrics/r_squared/README.md

Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>

* Update metrics/r_squared/README.md

* Update metrics/r_squared/Readme

* Added r_squared metric

* Update  metrics/r_squared/README.md

* Update r_squared metric

* Update  metrics/r_squared/README.md

* Update metrics/r_squared/app.py

* Update metrics/r_squared/r_squared.py

* Update metrics/r_squared/requirements.txt

* fix: imports and format code according to Black standard

* Fix: R-squared evaluation metric to round off value to 3 decimal places

---------

Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants