Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matthews correlation coefficient #362

Merged
merged 8 commits into from
Nov 17, 2022
Merged

Conversation

sanderland
Copy link
Contributor

@sanderland sanderland commented Nov 16, 2022

See #317

  • Refrained from adding 'micro' as an option for averaging, as I think it has too many pitfalls.
  • Would like to test a bit better, but not sure where to add this

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 16, 2022

The documentation is not available anymore as the PR was closed or merged.

@lvwerra lvwerra self-requested a review November 16, 2022 10:12
@lvwerra
Copy link
Member

lvwerra commented Nov 16, 2022

Thanks for adding this! The tests for metrics are in the docstrings itself. So if you add an example or two to the docstring the will be tested by the CI. Also to fix the style tests you can run make style && make quality.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sanderland sanderland marked this pull request as ready for review November 16, 2022 11:44
@sanderland
Copy link
Contributor Author

Should be all ready now @lvwerra

Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Would you mind also updating the README with the new options?

metrics/matthews_correlation/matthews_correlation.py Outdated Show resolved Hide resolved
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sanderland
Copy link
Contributor Author

@lvwerra gave it a shot, but there's not a lot of examples to go on as the multilabel config option is quite under-documented in general.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@lvwerra
Copy link
Member

lvwerra commented Nov 17, 2022

Thank you for adding this!

@lvwerra lvwerra merged commit 4ca8eed into huggingface:main Nov 17, 2022
@sanderland sanderland deleted the matthews branch November 17, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants