Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scikit-learn install in spaces #345

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Fix scikit-learn install in spaces #345

merged 1 commit into from
Nov 8, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Nov 8, 2022

For some reason sklearn used to work as a dependency but the correct way to install scikit-learn is by it's full name and the short term is only used in the library itself. This PR fixes this.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Contributor

@sashavor sashavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, didn't know the short name of sklearn can cause errors! good to know

@lvwerra lvwerra merged commit 6206bad into main Nov 8, 2022
@lvwerra lvwerra deleted the fix-sklearn-dependancy branch November 8, 2022 16:57
@kashif
Copy link
Contributor

kashif commented Nov 8, 2022

Ah yes thanks!

NimaBoscarino pushed a commit to NimaBoscarino/evaluate that referenced this pull request Nov 9, 2022
fix: change pip install from sklearn to scikit-learn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants