Stop using model-defined truncation in perplexity calculation #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
lvwerra
approved these changes
Nov 1, 2022
NimaBoscarino
pushed a commit
to NimaBoscarino/evaluate
that referenced
this pull request
Nov 9, 2022
…gface#333) * Stop using model-defined truncation * Formatting * If start token and also max length defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user doesn't explicitly pass in
max_length, we shouldn't truncate the inputs to perplexity at all.model.config.max_lengthis unreliable since it's named differently in every model (and sometimes not at all).I'd also be in support of removing the truncation option in entirety, but this seems like a good compromise for retaining previous existing functionality.
Closes #332.