Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HONEST yaml #303

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Fix HONEST yaml #303

merged 1 commit into from
Oct 4, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Sep 29, 2022

No description provided.

sashavor
sashavor approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@sashavor sashavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this! the description needs to start with a tab?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 29, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@mathemakitten
Copy link
Contributor

Sorry I missed this! the description needs to start with a tab?

See discussion in #296 — I'm trying to figure out if we can trigger this test to run on only new/changed files instead of all of them. For the moment, you can verify new YAML files manually with

with open('README.md') as f_yaml:
    x = yaml.safe_load_all(f_yaml)
    y = next(x)  # if it's invalid yaml then it'll throw an error

@sashavor sashavor merged commit 8e76263 into main Oct 4, 2022
@sashavor sashavor deleted the lvwerra-patch-1 branch October 4, 2022 17:28
NimaBoscarino pushed a commit that referenced this pull request Oct 17, 2022
@lvwerra @NimaBoscarino
Fix HONEST yaml (#303)
c075c02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashavor sashavor sashavor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lvwerra @HuggingFaceDocBuilderDev @mathemakitten @sashavor