-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CONTRIBUTING.md #293
Add CONTRIBUTING.md #293
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mathemakitten, looks great! Just one comment about community/canonical metrics.
CONTRIBUTING.md
Outdated
less than 30s; | ||
* Provide the *full* traceback if an exception is raised. | ||
|
||
### Do you want to implement a new metric? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should probably explain a bit the difference between canonical and community metric here since it is cause for confusion sometimes.
- Canonical: well established metrics
- Community: new or custom metrics
Similarly we could state above (did you find a bug) that if it's a community metric one can create a PR/issue right on the repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, please see changes :)
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
…valuate into hn-contributing-md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Adapted from the
transformers
anddatasets
versions; the main changes are in theDo you want to implement a new metric?
section which is specific toevaluate
.