Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove handle_impossible_answer from the default PIPELINE_KWARGS in the question answering evaluator #272

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Aug 23, 2022

This argument should be set depending on whether we infer a dataset in the format of squad_v1 or squad_v2, hence remove the default.

Fixing as well the depreciation of logger.warn for logger.warning.

cc @mathemakitten

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Contributor

@mathemakitten mathemakitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fxmarty!!

Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I think maybe having this as a class attribute in the first place is not ideal and we should rather do it in the __init__ so this is not shared across instances of the same evaluator. But we can fix this in a separate PR.

@lvwerra lvwerra merged commit d6bfc74 into huggingface:main Aug 24, 2022
mathemakitten pushed a commit that referenced this pull request Aug 24, 2022
…in the question answering evaluator (#272)

* fix handle_impossible_answer arg in question answering evaluator

* add default pipeline kwargs for all subclasses of evalautor

* trigger actions
mathemakitten pushed a commit that referenced this pull request Sep 23, 2022
…in the question answering evaluator (#272)

* fix handle_impossible_answer arg in question answering evaluator

* add default pipeline kwargs for all subclasses of evalautor

* trigger actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants