Clarify error message for ChrF no. references #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
added 2 commits
August 11, 2022 13:53
lvwerra
approved these changes
Aug 15, 2022
mathemakitten
pushed a commit
that referenced
this pull request
Aug 15, 2022
* clarifies error message * formatting * black
mathemakitten
pushed a commit
that referenced
this pull request
Sep 23, 2022
* clarifies error message * formatting * black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you give a different number of references and hypotheses to chrf, you get this error:
When you are only calculate chrf, it is clear that the error comes from calculating chrf. But if you do something like
it takes a moment to realize that chrf is causing the error and not bleu. Clarifying/reminding the user that chrf is implemented through sacrebleu can help.