-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change perplexity to be calculated with base e #242
Conversation
The documentation is not available anymore as the PR was closed or merged. |
A comparison, for reference, on the sentence Previously, base 2:
Now, base e: ppl = 70.6083 Compare with the canonical example in
And the usual:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this and fixing the docs. Looks good to me, the only thing I would add is an explicit comment in the docstring (_DESCRIPTION
) as well as at the very beginning of the readme that we compute ppl with base e
.
Merging with the open docs PR for perplexity, #238.
Closes #241.