Add Wilcoxon's signed rank test #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douwekiela
commented
Aug 9, 2022
comparisons/wilcoxon/README.md
Outdated
|
|
||
| ```python | ||
| wilcoxon = evaluate.load("wilcoxon") | ||
| results = wilcoxon.compute(predictions1=[-7, 123, 43, 4, 5], predictions2=[1337, -9, 1, 2, 3]) |
There was a problem hiding this comment.
Hrmm should probably make some of these floats to make clear that those are allowed too
|
The documentation is not available anymore as the PR was closed or merged. |
lvwerra
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Hi @douwekiela, thanks for the super clean PR. Left a comment regarding the feature types related to your own comment.
comparisons/wilcoxon/wilcoxon.py
Outdated
Comment on lines
64
to
69
| features=datasets.Features( | ||
| { | ||
| "predictions1": datasets.Value("int64"), | ||
| "predictions2": datasets.Value("int64"), | ||
| } | ||
| ), |
There was a problem hiding this comment.
If you want it to work for both int and float you can pass a list of dataset.Features and it then automatically detects which one works. You can have a look at BLEU. Alternatively, I think floats would probably work both cases anyway, no?
mathemakitten
pushed a commit
that referenced
this pull request
Aug 15, 2022
Add Wilcoxon's signed rank test for comparing model predictions, e.g. for testing whether the difference in BLEU score between two models is significant.
mathemakitten
pushed a commit
that referenced
this pull request
Sep 23, 2022
Add Wilcoxon's signed rank test for comparing model predictions, e.g. for testing whether the difference in BLEU score between two models is significant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured it'd be good to add a few more comparisons