make rouge support multi-ref #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
metrics/rouge/README.md
Outdated
| ### Inputs | ||
| - **predictions** (`list`): list of predictions to score. Each prediction | ||
| should be a string with tokens separated by spaces. | ||
| - **references** (`list`): list of reference for each prediction. Each | ||
| - **references** (`list` or `list[list]`): list of reference for each prediction or a list of several predictions. Each |
There was a problem hiding this comment.
nit: Should this be "a list of several references for this prediction" as opposed to "a list of several predictions"? I assume the change is meant to surface that each prediction can be correctly mapped to several references.
Otherwise I tested this and it LGTM :)
There was a problem hiding this comment.
Absolutely, thanks for noticing this!
mathemakitten
approved these changes
Aug 4, 2022
mathemakitten
pushed a commit
that referenced
this pull request
Aug 15, 2022
* make rouge support multi-ref * update rouge dependency * clean style * fix rouge dependency * fix readme
mathemakitten
pushed a commit
that referenced
this pull request
Sep 23, 2022
* make rouge support multi-ref * update rouge dependency * clean style * fix rouge dependency * fix readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of the
score_multimethod added inrouge_score==0.12.0and allows to pass multiple references per prediction. This makes this metric now compatible withbleuandmeteor.Closes #118