Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading error #222

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Fix loading error #222

merged 3 commits into from
Jul 29, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jul 29, 2022

When switching from GitHub to Hugging Face Hub as a source of the scripts in #180 the error changed when a file is not found from FileNotFoundError (GitHub) to ConnectionError. When the module_type needs to be inferred this fails as the error is not caught.

This PR should fix this.

@lvwerra lvwerra requested a review from sashavor July 29, 2022 13:04
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 29, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@sashavor sashavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the loading bug! yay! 💪

@lvwerra lvwerra merged commit 4ed51c9 into main Jul 29, 2022
@lvwerra lvwerra deleted the fix-loading-error branch July 29, 2022 13:20
mathemakitten pushed a commit that referenced this pull request Aug 3, 2022
* fix because hub throws `ConnectionError`

* fix error message

* update second catch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants