Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin rouge_score #220

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Unpin rouge_score #220

merged 1 commit into from
Aug 4, 2022

Conversation

albertvillanova
Copy link
Member

Once the issue has been fixed in their side with version 0.1.2, we can unpin it:

OK I've verified that 0.1.2 works in colab. Today I learned that colab uses python 3.7.

Follow-up of:

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 29, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

lvwerra
lvwerra approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused by your message: can we already merge this? :)

@albertvillanova
Copy link
Member Author

Yes: our CIs pip install the latest version of rouge_score

  • Before: their latest version was 0.0.7, which had a bug and was not importable
  • Now: their latest version is 0.1.2, which fixed their bug and is importable
    • Our CI passes with this version

@lvwerra
Copy link
Member

lvwerra commented Aug 4, 2022

Thanks @albertvillanova!

@lvwerra lvwerra merged commit fdb6dbf into main Aug 4, 2022
@lvwerra lvwerra deleted the albertvillanova-patch-1 branch August 4, 2022 12:18
mathemakitten pushed a commit that referenced this pull request Sep 23, 2022
@albertvillanova @mathemakitten
Unpin rouge_score (#220)
d7616a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvwerra lvwerra lvwerra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@albertvillanova @HuggingFaceDocBuilderDev @lvwerra