Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add poseval #195

Merged
merged 4 commits into from
Jul 22, 2022
Merged

add poseval #195

merged 4 commits into from
Jul 22, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jul 21, 2022

This PR adds the Poseval metric. Since Seqeval does not work well with data that is not in IOB format (see here) and since POS usually assigns one label per word with poseval each token is evaluated independently (as suggested here).

cc @fxmarty @lewtun since that's useful for the evalautor and Eval on the hub.

@lvwerra lvwerra requested a review from sashavor July 21, 2022 10:32
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 21, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@sashavor sashavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome possum! 🦝


## Limitations and bias

In contrast to seqeval the poseval metric treats each token independantly and computes the classification report overal all concatenated sequences.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a link to Seqeval here?

also, a few minor typos: "In contrast to seqeval, the poseval metric treats each token independently and computes the classification report over all concatenated sequences."

@@ -0,0 +1,113 @@
# Copyright 2020 The HuggingFace Evaluate Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit unrelated, but should we just massively update all of our code from 2020 to 2022? 😂

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once merged to main:

You should merge the main branch into this PR branch to incorporate the fix:

git checkout poseval
git fetch origin main
git merge origin/main
git push -u origin poseval

@lvwerra lvwerra merged commit 2c6d460 into main Jul 22, 2022
@lvwerra lvwerra deleted the poseval branch July 22, 2022 11:23
mathemakitten pushed a commit that referenced this pull request Aug 3, 2022
* add poseval

* fix style

* add suggestion from review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants