refactor evaluator base and task classes #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
evaluator
base and task classes based on discussions in #178 to make them a bit more abstract for new tasks and draw a clearer separation between base and task classes.Adding the performance should now be easy: measure inside
call_pipeline
and return an dict with which you can update theresult
dict inside thecompute
methods.Also if a user wants to pass a custom prediction postprocessing (as suggested by @craffel) before passing to the metric we can just overwrite the
predictions_processing
method or wrap the custom function around it.Let me know what you think @ola13 and @fxmarty.