Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bertscore idf #183

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Fix bertscore idf #183

merged 2 commits into from
Jul 13, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jul 13, 2022

This addresses #151: If no sentences for IDF are provided and the IDF dict is not computed and an error is raised during the scoring.

Also fixed the feature logic with the new logic allowing to specifying multiple feature types.

@lvwerra lvwerra requested review from sashavor and lhoestq July 13, 2022 09:14
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 13, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sashavor
sashavor approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@sashavor sashavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

@lvwerra lvwerra merged commit 8e481b1 into main Jul 13, 2022
@lvwerra lvwerra deleted the fix-bertscore-idf branch July 13, 2022 17:17
@lvwerra lvwerra mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashavor sashavor sashavor approved these changes

@lhoestq lhoestq Awaiting requested review from lhoestq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lvwerra @HuggingFaceDocBuilderDev @sashavor