Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forbid hyphens in template for module names #177

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jul 6, 2022

This PR adds a test for hyphens in module names when creating a new space with the template. If it contains hyphen an ValueError is thrown.

Fixes #171

@lvwerra lvwerra requested a review from sashavor July 6, 2022 10:21
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 6, 2022

The documentation is not available anymore as the PR was closed or merged.

@lvwerra lvwerra merged commit 210ae1a into main Jul 7, 2022
@lvwerra lvwerra deleted the forbid-hyphen-in-template branch July 7, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add warning/error when metric name includes a hyphen
2 participants