Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused fixtures from unittests #170

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jun 30, 2022

This PR removes unused fixtures in the unit tests for S3 and the Hugging Face Hub which were remnants of the datasets library. This makes #146 obsolete.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 30, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lvwerra lvwerra merged commit d7eee90 into main Jul 1, 2022
@lvwerra lvwerra deleted the remove-unused-fixtures branch July 1, 2022 07:45
@lvwerra lvwerra mentioned this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants