Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename input_texts to predictions in perplexity #157

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jun 24, 2022

This PR adresses #149 and renames the input to the perplexity metric to match the format used by other metrics. This makes the usage more uniform and will also allow to easily combine it with other NLP metrics.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 24, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@sashavor sashavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super useful, @lvwerra , thank you! 🤗

Copy link
Contributor

@TristanThrush TristanThrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two little things that I noticed, otherwise LGTM

metrics/perplexity/README.md Outdated Show resolved Hide resolved
metrics/perplexity/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TristanThrush TristanThrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lvwerra lvwerra merged commit 9be38a7 into main Jun 28, 2022
@lvwerra lvwerra deleted the fix-perplexity-inputs branch June 28, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants