Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datasets download imports #143

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Fix datasets download imports #143

merged 2 commits into from
Jun 15, 2022

Conversation

albertvillanova
Copy link
Member

@lvwerra
Copy link
Member

lvwerra commented Jun 15, 2022

Thanks for the PR @albertvillanova.

This is also fixes #142

@NimaBoscarino
Copy link
Contributor

NimaBoscarino commented Jun 15, 2022

Ah you beat me to it! 😄 (Edit: deleted my branch)

I think there's another one to fix under src/evaluate/inspect.py, which is currently

from datasets.utils import DownloadConfig

@lhoestq
Copy link
Member

lhoestq commented Jun 15, 2022

FYI I also opened huggingface/datasets#4497 to re-add them in datasets, we'll do a patch release soon.

Note that these imports are deprecated, so it's nice if you can use the new import :)

@lvwerra
Copy link
Member

lvwerra commented Jun 15, 2022

These changes would require datasets>=2.3.0 though, right?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 15, 2022

The documentation is not available anymore as the PR was closed or merged.

@albertvillanova
Copy link
Member Author

albertvillanova commented Jun 15, 2022

@lvwerra with this fix, evaluate does not need to care about the version of datasets: the import is done from the top level and it is datasets that handles the subpackage internally, depending on its version.

Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this :)

@lvwerra lvwerra merged commit 3fb6e68 into main Jun 15, 2022
@lvwerra lvwerra deleted the fix-datasets-download branch July 24, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants