Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix revision string if it is a python version #129

Merged
merged 4 commits into from
Jun 8, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jun 8, 2022

Due to the change from X.X.X to vX.X.X format for release tags the loading from version is broken. E.g. when loading accuracy:

import evaluate
acc = evaluate.load("accuracy")

the following warning is displayed

Couldn't find a directory or a metric named 'accuracy' in this version. It was picked from the master branch on github instead.

because there is no 0.1.0 (but v0.1.0) tag in the repository. We will switch to loading all metrics from Spaces anyway, but this PR should fix this in the meantime.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 8, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lvwerra lvwerra merged commit f334d53 into main Jun 8, 2022
@lvwerra lvwerra deleted the fix-loading-metric-from-version branch July 24, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants