Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spaces description in metadata #123

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Fix spaces description in metadata #123

merged 3 commits into from
Jun 8, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jun 3, 2022

This PR adds the description to the metadata of each evaluation module's space.

@lvwerra lvwerra requested a review from julien-c June 3, 2022 16:04
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 3, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Question: which library/settings do you use to output your YAML? or do you do it manually?

@lvwerra
Copy link
Member Author

lvwerra commented Jun 6, 2022

I added the descriptions manually to the README, why? Something off?

@julien-c
Copy link
Member

julien-c commented Jun 6, 2022

hmm it's just that i am researching the recommended YAML formatting to minimize the probability of style changes when updating YAML programmatically: huggingface/hub-docs#164

I'm starting to think that we should promote pyyaml as the recommended formatter.

No big deal for this PR though, we can merge like that!

@lvwerra lvwerra merged commit 05209ec into main Jun 8, 2022
@lvwerra lvwerra deleted the fix-metrics-metadata branch July 24, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants