Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding doc strings + adding a faster tokenized doc merger #90

Merged
merged 66 commits into from
Feb 29, 2024

Conversation

thomwolf
Copy link
Member

No description provided.

Copy link
Collaborator

@guipenedo guipenedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new docstrings and the fix on the urlstats. I'm okay with moving the docstrings from init up to the top of the classes.

There are some changes that will break things and I don't see a reason for (fork, the logging one, removing tolist at one point).
For the new tokens merger I messaged you directly.
The tests are also broken (code quality etc)

src/datatrove/executor/base.py Outdated Show resolved Hide resolved
src/datatrove/executor/local.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/dedup/minhash.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/dedup/minhash.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/dedup/minhash.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/tokens/merger.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/tokens/merger.py Show resolved Hide resolved
src/datatrove/pipeline/tokens/merger.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/tokens/tokenizer.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/tokens/tokenizer.py Outdated Show resolved Hide resolved
src/datatrove/io.py Outdated Show resolved Hide resolved
src/datatrove/io.py Outdated Show resolved Hide resolved
src/datatrove/io.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/base.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/dedup/minhash.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/readers/jsonl.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/stats/urls.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/tokens/tokenizer.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/tokens/tokenizer.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/tokens/merger.py Outdated Show resolved Hide resolved
@guipenedo guipenedo merged commit 03a9d9a into main Feb 29, 2024
4 checks passed
@guipenedo guipenedo deleted the adding-doc-strings branch February 29, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants