-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding doc strings + adding a faster tokenized doc merger #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new docstrings and the fix on the urlstats. I'm okay with moving the docstrings from init up to the top of the classes.
There are some changes that will break things and I don't see a reason for (fork
, the logging one, removing tolist
at one point).
For the new tokens merger I messaged you directly.
The tests are also broken (code quality etc)
No description provided.