Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple enhancement for readibility #253

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Simple enhancement for readibility #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/datatrove/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,10 @@ def list_files(
Get a list of files on this directory. If `subdirectory` is given will search in `path/subdirectory`. If
glob_pattern is given, it will only return files that match the pattern, which can be used to match a given
extension, for example `*.myext`. Be careful with subdirectories when using glob (use ** if you want to match
any subpath). Args: subdirectory: str: (Default value = "") recursive: bool: (Default value = True)
any subpath).

Args: subdirectory: str: (Default value = "")
recursive: bool: (Default value = True)
glob_pattern: str | None: (Default value = None)

Returns: a list of file paths, relative to `self.path`
Expand Down
2 changes: 1 addition & 1 deletion src/datatrove/tools/check_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def open_file(path):
datafiles = input_folder.list_files(glob_pattern="*.ds")
datafiles_index = input_folder.list_files(glob_pattern="*.ds.index")
datafiles_loss = input_folder.list_files(glob_pattern="*.ds.loss")
check_loss = not not datafiles_loss
check_loss = bool(datafiles_loss)
assert len(datafiles) == len(datafiles_index) and (not check_loss or len(datafiles) == len(datafiles_loss)), (
"Mismatch between number of .ds, " ".ds.index and/or .ds.loss files"
)
Expand Down