Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url deduplication #145

Merged
merged 23 commits into from
Apr 12, 2024
Merged

Url deduplication #145

merged 23 commits into from
Apr 12, 2024

Conversation

hynky1999
Copy link
Contributor

Adds url deduplication

  • Allows for prioritization of documents during deduplication
  • The algorithmic side of the deduplication is the same compared to sentence dededuplication

Nits

  • We can prob merge the url deduplication and sentence deduplication code in future, to make it more dry, but as of right now I don't see a benefit.

@hynky1999 hynky1999 requested a review from guipenedo April 2, 2024 12:33
@guipenedo
Copy link
Collaborator

agreed on basically merging all exact deduplication approaches into a single one, but we can refactor this later

@hynky1999 hynky1999 requested a review from guipenedo April 9, 2024 18:02
guipenedo
guipenedo requested changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@guipenedo guipenedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general, but the reading thing still needs to be ironed out. ideally the sent dedup code should also be changed to use it

examples/url_deduplication.py Show resolved Hide resolved
src/datatrove/pipeline/dedup/url_dedup.py Show resolved Hide resolved
src/datatrove/utils/binaryio.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/dedup/url_dedup.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/dedup/url_dedup.py Outdated Show resolved Hide resolved
src/datatrove/utils/text.py Show resolved Hide resolved
tests/pipeline/test_url_deduplication.py Show resolved Hide resolved
guipenedo
guipenedo requested changes Apr 12, 2024
View reviewed changes
src/datatrove/pipeline/dedup/sentence_dedup.py Outdated Show resolved Hide resolved
src/datatrove/pipeline/dedup/url_dedup.py Outdated Show resolved Hide resolved
src/datatrove/utils/binaryio.py Outdated Show resolved Hide resolved
hynky1999 and others added 3 commits April 12, 2024 14:29
@hynky1999 @guipenedo
Update src/datatrove/pipeline/dedup/sentence_dedup.py
f4c68d3 
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
@hynky1999 @guipenedo
Update src/datatrove/utils/binaryio.py
daa30d5 
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
@hynky1999 @guipenedo
Update src/datatrove/pipeline/dedup/url_dedup.py
453d5da 
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
@guipenedo guipenedo merged commit 209ebec into huggingface:main Apr 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guipenedo guipenedo guipenedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hynky1999 @guipenedo