Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apex build command #1689

Closed
wants to merge 1 commit into from
Closed

Conversation

janEbert
Copy link

@janEbert janEbert commented Jul 5, 2023

Due to pip having deprecated --global-option and --build-option, the new build command will be highly relevant in the future (removal is planned for 23.3, see pypa/pip#11859).

See also NVIDIA/apex#1690 for why the command is different from the Apex README.

Due to pip having deprecated `--global-option` and `--build-option`,
this will be highly relevant in the future (removal is planned for 23.3,
see pypa/pip#11859).
@muellerzr
Copy link
Collaborator

CC @pacman100

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@janEbert
Copy link
Author

janEbert commented Jul 6, 2023

Actually this may not be the correct command after all, see NVIDIA/apex#1679 (comment).
It suffers from the same deprecations.

Oops, I didn't even push the change I meant to this branch. :)

@janEbert janEbert marked this pull request as draft July 6, 2023 06:34
@janEbert
Copy link
Author

janEbert commented Jul 6, 2023

If NVIDIA/apex#1692 is accepted as the official solution, the current state will be fine to use.

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs, LGTM!

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants