Skip to content

Commit

Permalink
pythongh-93963: Remove deprecated names from importlib.abc (python#11…
Browse files Browse the repository at this point in the history
…9720)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
  • Loading branch information
2 people authored and noahbkim committed Jul 11, 2024
1 parent b4c5f05 commit 1188a47
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 25 deletions.
34 changes: 24 additions & 10 deletions Doc/whatsnew/3.14.rst
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ ast
---

Added :func:`ast.compare` for comparing two ASTs.
(Contributed by Batuhan Taskaya and Jeremy Hylton in :issue:`15987`)
(Contributed by Batuhan Taskaya and Jeremy Hylton in :issue:`15987`.)



Expand All @@ -108,6 +108,13 @@ Deprecated
Removed
=======

argparse
--------

* Remove the *type*, *choices*, and *metavar* parameters
of :class:`!argparse.BooleanOptionalAction`.
They were deprecated since 3.12.

ast
---

Expand Down Expand Up @@ -137,27 +144,34 @@ ast

(Contributed by Alex Waygood in :gh:`119562`.)


argparse
--------

* Remove the *type*, *choices*, and *metavar* parameters
of :class:`!argparse.BooleanOptionalAction`.
They were deprecated since 3.12.

collections.abc
---------------

* Remove :class:`!collections.abc.ByteString`. It had previously raised a
:exc:`DeprecationWarning` since Python 3.12.


email
-----

* Remove the *isdst* parameter from :func:`email.utils.localtime`.
(Contributed by Hugo van Kemenade in :gh:`118798`.)

importlib
---------

* Remove deprecated :mod:`importlib.abc` classes:

* :class:`!importlib.abc.ResourceReader`
* :class:`!importlib.abc.Traversable`
* :class:`!importlib.abc.TraversableResources`

Use :mod:`importlib.resources.abc` classes instead:

* :class:`importlib.resources.abc.Traversable`
* :class:`importlib.resources.abc.TraversableResources`

(Contributed by Jason R. Coombs and Hugo van Kemenade in :gh:`93963`.)

itertools
---------

Expand Down
15 changes: 0 additions & 15 deletions Lib/importlib/abc.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
import abc
import warnings

from .resources import abc as _resources_abc


__all__ = [
'Loader', 'MetaPathFinder', 'PathEntryFinder',
Expand All @@ -25,19 +23,6 @@
]


def __getattr__(name):
"""
For backwards compatibility, continue to make names
from _resources_abc available through this module. #93963
"""
if name in _resources_abc.__all__:
obj = getattr(_resources_abc, name)
warnings._deprecated(f"{__name__}.{name}", remove=(3, 14))
globals()[name] = obj
return obj
raise AttributeError(f'module {__name__!r} has no attribute {name!r}')


def _register(abstract_cls, *classes):
for cls in classes:
abstract_cls.register(cls)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Remove deprecated names from ``importlib.abc`` as found in
``importlib.resources.abc``.

0 comments on commit 1188a47

Please sign in to comment.