Use relative paths in directory listing #661 #732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. Thanks for your all continuous work on this! I've fixed #661, please review.
Please ensure that your pull request fulfills these requirements:
master
branchWhat is the purpose of this pull request? (bug fix, enhancement, new feature,...)
#661
What changes did you make?
Paths in directory listing to be relative
Before:
![image](https://user-images.githubusercontent.com/34891695/135483758-53776bfd-62e0-42ed-8aea-b88fa38c0059.png)
After:
![image](https://user-images.githubusercontent.com/34891695/135481787-9610f43b-42ba-4a7e-9f56-6c56139eb276.png)
Is there anything you'd like reviewers to focus on?
I'm not sure that the tests are fixed properly, so please focus on those.
Please provide testing instructions, if applicable:
I tested in following way:
npm run test
There was no error and it says "371 passing".
./bin/http-server ./
, check the paths onhttp://localhost:8080
Result image is above.