Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used table format for README summary of Commands. #715

Merged
merged 10 commits into from
Aug 12, 2021

Conversation

wayiam
Copy link
Contributor

@wayiam wayiam commented Aug 8, 2021

Please ensure that your pull request fulfills these requirements:

  • The pull request is being made against the master branch
  • Tests for the changes have been added (for bug fixes / features)

What is the purpose of this pull request? (bug fix, enhancement, new feature,...)

What changes did you make?

Provide some example code that this change will affect, if applicable:

Is there anything you'd like reviewers to focus on?

Please provide testing instructions, if applicable:

Copy link
Member

@thornjad thornjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! What do you think about adding a third column to display default values?

README.md Outdated Show resolved Hide resolved
Also set the text to left aligned.
Created Column for default values and set text to left aligned.
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
wayiam and others added 4 commits August 10, 2021 11:26
Co-authored-by: Jade Michael Thornton <jademichael@jmthornton.net>
Co-authored-by: Jade Michael Thornton <jademichael@jmthornton.net>
Co-authored-by: Jade Michael Thornton <jademichael@jmthornton.net>
Co-authored-by: Jade Michael Thornton <jademichael@jmthornton.net>
@thornjad thornjad added this to the v14.0 milestone Aug 11, 2021
Copy link
Member

@thornjad thornjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wayiam
Copy link
Contributor Author

wayiam commented Aug 11, 2021

Hey, is there anything left to do in my PR?

@thornjad
Copy link
Member

Was just waiting for the tests to pass! Looks all good!

@thornjad thornjad merged commit eec8c36 into http-party:master Aug 12, 2021
@thornjad thornjad mentioned this pull request Aug 16, 2021
2 tasks
@thornjad thornjad added patch version Small, non-breaking, bug fix or trivial change documentation Human facing code. labels Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Human facing code. patch version Small, non-breaking, bug fix or trivial change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants