Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding output of server settings on startup #654

Merged
merged 3 commits into from
Aug 20, 2021

Conversation

ColtonHerrod
Copy link
Contributor

@ColtonHerrod ColtonHerrod commented Sep 13, 2020

Please ensure that your pull request fulfills these requirements:

  • The pull request is being made against the master branch
  • Tests for the changes have been added (for bug fixes / features)

What is the purpose of this pull request? (bug fix, enhancement, new feature,...)

Resolves #529 by adding server settings logs to startup.

What changes did you make?
Changed the startup function to output logs of common server settings.
No unit tests added, as this is not changing any service functionality.

Provide some example code that this change will affect, if applicable:
Affects all server startup commands.

Is there anything you'd like reviewers to focus on?
None

Please provide testing instructions, if applicable:
Validate that the settings are displayed appropriately.

@ColtonHerrod
Copy link
Contributor Author

Is there a way to re-run the Travis build without pushing additional code? It looks like the run failed due to an NVM error.

@thornjad
Copy link
Member

Hm, I'm don't see any options. You could do a git commit --allow-empty and push that. It's not the best, but I don't see a way to re-run this branch and let GitHub know about it.

@thornjad thornjad self-requested a review October 12, 2020 14:37
@ColtonHerrod
Copy link
Contributor Author

Looks like that resolved it, thanks for the tip.

@thornjad thornjad modified the milestones: v14.0, v13.1 Aug 16, 2021
@thornjad thornjad added the patch version Small, non-breaking, bug fix or trivial change label Aug 20, 2021
@thornjad thornjad removed this from the v14.0 milestone Aug 20, 2021
@thornjad thornjad merged commit 3f1c6b0 into http-party:master Aug 20, 2021
@ColtonHerrod ColtonHerrod deleted the feature/log_settings branch August 20, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch version Small, non-breaking, bug fix or trivial change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: show server settings info at start
2 participants