Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing String to Encoding::encode #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow passing String to Encoding::encode #77

wants to merge 2 commits into from

Commits on Dec 22, 2021

  1. Allow passing String to Encoding::encode 

    In the common case when converting from UTF8 to UTF8, or the string is all ASCII, this avoids an
extra heap allocation for the caller if they only have a `String` available.
Previously, they would have to call `encoding.encode(&string).into_owned()` to avoid lifetime errors.
    @jyn514
    jyn514 committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    e58dc4a View commit details
    Browse the repository at this point in the history

  2. Make most of encode() non-generic to avoid heavy monomorphization c… 

    …osts
    @jyn514
    jyn514 committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    5ea8b3d View commit details
    Browse the repository at this point in the history