Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal CI workflow using GitHub Actions #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhysd
Copy link

@rhysd rhysd commented Apr 17, 2024

Hi, thank you for maintaining this great crate.

This PR adds a minimal CI workflow which will help you notice build breaks easily. Since this crate is very popular (15720778 times downloaded recently), I think it is important to keep all tests pass successfully.

The README.md file contains a Travis CI badge so I guess this project used it. However Travis CI no longer works at this time.

This minimal GitHub Actions CI workflow does the following:

  • Unit test
    • Runs cargo test with stable Rust on Linux, macOS, and Windows
  • Formatting
    • Check code formatting with rustfmt with nightly toolchain since the configuration in rustfmt.toml is only available on nightly

Here is an example of workflow run on my fork: https://github.com/rhysd/encoding_rs/actions/runs/8777306722

@rhysd rhysd force-pushed the github-actions branch 2 times, most recently from 3f02454 to 2ed3fc8 Compare April 17, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant