Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tutorial and FAQ #1689

Merged
merged 4 commits into from
Jul 6, 2023
Merged

update tutorial and FAQ #1689

merged 4 commits into from
Jul 6, 2023

Conversation

lucaudill
Copy link
Collaborator

The tutorial has been stale since adding seccomp to --force. This PR addresses that.

@lucaudill lucaudill self-assigned this Jun 19, 2023
@lucaudill lucaudill requested a review from reidpr June 19, 2023 22:11
@lucaudill lucaudill marked this pull request as ready for review June 19, 2023 22:11
@lucaudill lucaudill removed the request for review from reidpr June 21, 2023 16:56
@lucaudill lucaudill requested a review from reidpr June 23, 2023 15:21
Copy link
Collaborator

@reidpr reidpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; LMK if you like my tidy commit and if so I'll merge.

@lucaudill
Copy link
Collaborator Author

lucaudill commented Jul 3, 2023

@reidpr I like your wording. I'm tempted to put the admonition a little higher up, just so it's a little more visible though.

@reidpr
Copy link
Collaborator

reidpr commented Jul 5, 2023

@reidpr I like your wording. I'm tempted to put the admonition a little higher up, just so it's a little more visible though.

Sure. My only reasoning was that then we had an admonition followed by the opening paragraph both starting "This section..." which seemed awkward.

@lucaudill lucaudill requested a review from reidpr July 5, 2023 20:38
@reidpr reidpr added this to the 0.34 milestone Jul 6, 2023
@reidpr reidpr closed this Jul 6, 2023
@reidpr reidpr reopened this Jul 6, 2023
@reidpr reidpr merged commit 3a25b29 into master Jul 6, 2023
@reidpr reidpr deleted the update-tutorial branch July 6, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants