Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update fedora build script for python 3 #1584

Merged
merged 4 commits into from
Mar 10, 2023
Merged

update fedora build script for python 3 #1584

merged 4 commits into from
Mar 10, 2023

Conversation

lucaudill
Copy link
Collaborator

No description provided.

@lucaudill lucaudill requested review from reidpr and j-ogas March 8, 2023 23:40
j-ogas
j-ogas previously requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@j-ogas j-ogas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does shlex come standard with python3? If not, we should probably guard against the case where it is missing. Alternatively, we may want to update autoconf to only install this script if the requisites are met.

@lucaudill
Copy link
Collaborator Author

lucaudill commented Mar 9, 2023 •
edited
Loading

shlex is listed on the page for the python standard library. From that page:

[T]his library reference manual describes the standard library that is distributed with Python. It also describes some of the optional components that are commonly included in Python distributions.

I'm not sure if this means that shlex is always bundled with python, or if it's just "commonly included"...

@reidpr
Copy link
Collaborator

reidpr commented Mar 10, 2023 •
edited
Loading

I'm not aware of any stdlib modules that don't come always bundled, unless for the wrong OS or something like that. Regardless we do use shlex elsewhere already.

@lucaudill lucaudill marked this pull request as ready for review March 10, 2023 19:26
@reidpr reidpr added this to the 0.32 milestone Mar 10, 2023
@reidpr reidpr dismissed j-ogas’s stale review March 10, 2023 23:16

concern addressed

@reidpr reidpr merged commit 113d0be into master Mar 10, 2023
@reidpr reidpr deleted the update-fedora-build branch March 10, 2023 23:17
@lucaudill lucaudill mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidpr reidpr reidpr approved these changes

@j-ogas j-ogas j-ogas left review comments

Assignees

@lucaudill lucaudill

Labels
bug install medium
Projects
None yet
Milestone
0.32
Development

Successfully merging this pull request may close these issues.
3 participants
@lucaudill @reidpr @j-ogas